Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ELB] Make persistence.type Optional in lb_pool_v2 #1052

Merged
merged 3 commits into from
May 11, 2021
Merged

[ELB] Make persistence.type Optional in lb_pool_v2 #1052

merged 3 commits into from
May 11, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented May 11, 2021 •
edited
Loading

Summary of the Pull Request

Make persistence.type Optional field
Fixes: #1027

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccLBV2Pool_basic
--- PASS: TestAccLBV2Pool_basic (166.85s)
=== RUN   TestAccLBV2Pool_persistenceNull
--- PASS: TestAccLBV2Pool_persistenceNull (115.11s)
PASS

Process finished with the exit code 0

@lego963 lego963 added the gate Merge PR label May 11, 2021
@otc-zuul
Copy link

otc-zuul bot commented May 11, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit be48427 into devel May 11, 2021
@otc-zuul otc-zuul bot deleted the lb-pool branch May 11, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ELB][Listener] persistence should be disabled when set to null
2 participants
@lego963 @anton-sidelnikov