Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip reading AS options if AS is disabled #1071

Merged
merged 1 commit into from
May 20, 2021
Merged

Skip reading AS options if AS is disabled #1071

merged 1 commit into from
May 20, 2021

Conversation

outcatcher
Copy link
Contributor

Summary of the Pull Request

Fix rewriting AS options with empty values

Resolve #1041

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCENodePoolsV3_basic
--- PASS: TestAccCCENodePoolsV3_basic (857.19s)
=== RUN   TestAccCCENodePoolsV3_randomAZ
--- PASS: TestAccCCENodePoolsV3_randomAZ (659.56s)
PASS

Process finished with the exit code 0

@outcatcher
Skip reading AS options if AS is disabled
e168a78 
Fix rewriting AS options with empty values

Make `cce_node_pool_v3` tests use defined cluster
@outcatcher outcatcher requested a review from lego963 May 20, 2021 15:47
@outcatcher outcatcher added the gate Merge PR label May 20, 2021
@otc-zuul
Copy link

otc-zuul bot commented May 20, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 43a202f into devel May 20, 2021
@otc-zuul otc-zuul bot deleted the cce/node-pool-as branch May 20, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CCE][NODEPOOL] Required change of 4 variables when autoscale is disabled
2 participants
@outcatcher @lego963