Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of infinite retrial in Node Pool creation #1075

Merged
merged 1 commit into from
May 21, 2021
Merged

Get rid of infinite retrial in Node Pool creation #1075

merged 1 commit into from
May 21, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented May 21, 2021 •
edited
Loading

Summary of the Pull Request

Retry 403 only once

Refactor cce_node_pool resource

Fix #1065

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCENodePoolsV3_basic
--- PASS: TestAccCCENodePoolsV3_basic (799.02s)
=== RUN   TestAccCCENodePoolsV3_randomAZ
--- PASS: TestAccCCENodePoolsV3_randomAZ (732.14s)
PASS

Process finished with the exit code 0

@outcatcher
Get rid of infinite retrial in Node Pool creation
e7de360 
Retry 403 only once

Refactor `cce_node_pool` resource
@outcatcher outcatcher requested a review from lego963 May 21, 2021 16:04
@outcatcher
Copy link
Contributor Author

recheck

@outcatcher outcatcher added the gate Merge PR label May 21, 2021
@otc-zuul
Copy link

otc-zuul bot commented May 21, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 0457337 into devel May 21, 2021
@otc-zuul otc-zuul bot deleted the cce-node-pool-403 branch May 21, 2021 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CCE] Node pool creation won't timeout on 403 error
2 participants
@outcatcher @lego963