Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCE] Add missing KMS config #1165

Merged
merged 4 commits into from
Jun 25, 2021
Merged

[CCE] Add missing KMS config #1165

merged 4 commits into from
Jun 25, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Jun 25, 2021 •
edited
Loading

Summary of the Pull Request

Add missing kms config in resource/opentelekomcloud_cce_node_pool_v3
Fixes: #1161
Fixes: #1157

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCENodePoolsV3_basic
--- PASS: TestAccCCENodePoolsV3_basic (1017.89s)
=== RUN   TestAccCCENodePoolsV3_randomAZ
--- PASS: TestAccCCENodePoolsV3_randomAZ (793.57s)
=== RUN   TestAccCCENodePoolsV3EncryptedVolume
--- PASS: TestAccCCENodePoolsV3EncryptedVolume (720.49s)
PASS

Process finished with the exit code 0

@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team June 25, 2021 12:12
outcatcher
outcatcher suggested changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@outcatcher outcatcher left a comment •
edited by lego963
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kms_id is not set in create/update, but is not computed-only

otc-zuul[bot]
otc-zuul bot previously approved these changes Jun 25, 2021
View reviewed changes
@lego963
Copy link
Contributor Author

lego963 commented Jun 25, 2021 •
edited
Loading

He is set in create DataVolumes: resourceCCEDataVolume(d),
This func resourceCCEDataVolume() is coming from cce_node_v3 and it uses kms_id
Update we don't have :(

@outcatcher outcatcher self-requested a review June 25, 2021 12:31
outcatcher
outcatcher previously approved these changes Jun 25, 2021
View reviewed changes
@lego963 lego963 added the gate Merge PR label Jun 25, 2021
@otc-zuul
Copy link

otc-zuul bot commented Jun 25, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 9edb040 into devel Jun 25, 2021
@otc-zuul otc-zuul bot deleted the cce-nodepool-kms branch June 25, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCE Nodepool cannot be created, missing encryption key CCE Node Data Encryption for Node Pools
3 participants
@lego963 @outcatcher @anton-sidelnikov