Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix of UDP-CONNECT #634

Merged
merged 1 commit into from
Sep 29, 2020
Merged

Conversation

macheins
Copy link
Contributor

"UDP-CONNECT" should be "UDP_CONNECT" as (correctly) stated in the docs an by the API:

Error: Unable to create monitor: Bad request with: [POST https://vpc.eu-de.otc.t-systems.com/v2.0/lbaas/healthmonitors], error message: {"NeutronError": {"message": "Invalid input for type. Reason: 'UDP-CONNECT' is not in ('HTTP', 'TCP', 'UDP_CONNECT').", "type": "HTTPBadRequest", "detail": ""}}

As it seems to be a very simple validation bug (typo?) I just created a quick fix, not a proper PR.
I leave it to others to turn this into a proper PR and maybe add a proper test case.

should be UDP_CONNECT
@outcatcher outcatcher added the gate Merge PR label Sep 29, 2020
@outcatcher

This comment has been minimized.

@otc-zuul
Copy link

otc-zuul bot commented Sep 29, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 03e4348 into opentelekomcloud:master Sep 29, 2020
@outcatcher outcatcher added this to the v1.20.2 milestone Sep 29, 2020
@macheins macheins deleted the fix-udp-connect branch September 29, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gate Merge PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants