Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RDSv3: Fix not assigning public IP #658

Merged
merged 2 commits into from
Oct 21, 2020
Merged

RDSv3: Fix not assigning public IP #658

merged 2 commits into from
Oct 21, 2020

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Oct 20, 2020 •
edited by outcatcher
Loading

Summary of the Pull Request

Somewhere public_eips field overrides, just up d.Get("public_eips") fixes this issue

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccRdsInstanceV3_basic
--- PASS: TestAccRdsInstanceV3_basic (663.19s)
=== RUN   TestAccRdsInstanceV3_ip_assign
--- PASS: TestAccRdsInstanceV3_ip_assign (722.43s)
PASS

Process finished with exit code 0

otc-zuul[bot]
otc-zuul bot previously approved these changes Oct 20, 2020
View reviewed changes
@outcatcher

This comment has been minimized.

Sign in to view
@outcatcher outcatcher changed the title Move up get info about public_ips RDSv3: Fix not assigning public IP Oct 21, 2020
@lego963 lego963 added the gate Merge PR label Oct 21, 2020
@otc-zuul
Copy link

otc-zuul bot commented Oct 21, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 5a47490 into master Oct 21, 2020
@otc-zuul otc-zuul bot deleted the r/rdsv3-eip-assign branch October 21, 2020 08:23
@outcatcher outcatcher added this to the v1.21.1 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

Assignees
No one assigned
Labels
gate Merge PR
Projects
None yet
Milestone
v1.21.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lego963 @outcatcher