Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with delete request in as_group #722

Merged
merged 10 commits into from
Nov 25, 2020
Merged

Fix issue with delete request in as_group #722

merged 10 commits into from
Nov 25, 2020

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Nov 25, 2020 •
edited
Loading

Summary of the Pull Request

Add update min_instance_number before delete

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccASV1Group_basic
--- PASS: TestAccASV1Group_basic (96.70s)
=== RUN   TestAccASV1Group_RemoveWithSetMinNumber
--- PASS: TestAccASV1Group_RemoveWithSetMinNumber (150.02s)
PASS

Process finished with exit code 0

@lego963
Minor changes
4639b4e 
Add update min_instance_number before delete
@lego963 lego963 marked this pull request as draft November 25, 2020 08:00
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 25, 2020
View reviewed changes
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 25, 2020
View reviewed changes
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 25, 2020
View reviewed changes
@lego963 lego963 marked this pull request as ready for review November 25, 2020 10:00
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 25, 2020
View reviewed changes
outcatcher
outcatcher suggested changes Nov 25, 2020
View reviewed changes
opentelekomcloud/resource_opentelekomcloud_as_group_v1.go Outdated Show resolved Hide resolved
opentelekomcloud/validators.go Outdated Show resolved Hide resolved
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 25, 2020
View reviewed changes
@lego963 lego963 added the gate Merge PR label Nov 25, 2020
outcatcher
outcatcher suggested changes Nov 25, 2020
View reviewed changes
opentelekomcloud/validators.go Outdated Show resolved Hide resolved
outcatcher
outcatcher previously approved these changes Nov 25, 2020
View reviewed changes
@lego963
Copy link
Contributor Author

lego963 commented Nov 25, 2020

recheck

@otc-zuul
Copy link

otc-zuul bot commented Nov 25, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit a4f8d90 into master Nov 25, 2020
@otc-zuul otc-zuul bot deleted the fix-as-group branch November 25, 2020 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lego963 @outcatcher @anton-sidelnikov