Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dds_instance_v3 data-source #725

Merged
merged 4 commits into from
Nov 27, 2020
Merged

Implement dds_instance_v3 data-source #725

merged 4 commits into from
Nov 27, 2020

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Nov 26, 2020 •
edited
Loading

Summary of the Pull Request

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccDDSInstanceV3DataSource_basic
--- PASS: TestAccDDSInstanceV3DataSource_basic (739.61s)
PASS

Process finished with exit code 0

otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 26, 2020
View reviewed changes
@lego963
Minor changes
ea72144 
Fix misprint in dds_flavors doc

Dds instance data source initial commit
otc-zuul[bot]
otc-zuul bot previously approved these changes Nov 26, 2020
View reviewed changes
@lego963 lego963 marked this pull request as ready for review November 27, 2020 08:31
@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team November 27, 2020 08:32
@lego963

This comment has been minimized.

Sign in to view
1 similar comment
@lego963
Copy link
Contributor Author

lego963 commented Nov 27, 2020

recheck

@lego963 lego963 added the gate Merge PR label Nov 27, 2020
@otc-zuul
Copy link

otc-zuul bot commented Nov 27, 2020

Build succeeded.

@otc-zuul otc-zuul bot merged commit 5b69b9d into master Nov 27, 2020
@otc-zuul otc-zuul bot deleted the d/dds-instance branch November 27, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lego963 @outcatcher @anton-sidelnikov