Allow using OBS client without AK/SK #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lego963
previously approved these changes
Dec 3, 2020
anton-sidelnikov
previously approved these changes
Dec 3, 2020
![otc-zuul[bot]](https://avatars.githubusercontent.com/in/11628?s=60&v=4){kind=small}
This affects following resources: - `opentelekomcloud_obs_bucket` - `opentelekomcloud_obs_bucket_object`
outcatcher
dismissed stale reviews from otc-zuul, anton-sidelnikov, and lego963
via
4b64649
outcatcher
force-pushed
the
feature/obs-without-aksk
branch
from
5e16f21
to
4b64649
Compare
lego963
approved these changes
Dec 3, 2020
anton-sidelnikov
approved these changes
Dec 3, 2020
|
Build succeeded.
|
4 tasks
outcatcher
added a commit
that referenced
this pull request
Dec 3, 2020
otc-zuul bot
pushed a commit
that referenced
this pull request
Dec 3, 2020
Remove `credentials` from `obs_bucket` and `obs_bucket_object` Summary of the Pull Request Revert #732 The existing implementation is no more useful after implementing #745 As it's implemented during the same release, so no deprecation needs to be done PR Checklist Refers to: #745, #732 Tests added/passed. Documentation updated. Schema updated. Acceptance Steps Performed W/o AK/SK Bucket: === RUN TestAccObsBucket_basic --- PASS: TestAccObsBucket_basic (18.81s) === RUN TestAccObsBucket_tags --- PASS: TestAccObsBucket_tags (10.10s) === RUN TestAccObsBucket_versioning --- PASS: TestAccObsBucket_versioning (18.33s) === RUN TestAccObsBucket_logging --- PASS: TestAccObsBucket_logging (14.59s) === RUN TestAccObsBucket_lifecycle --- PASS: TestAccObsBucket_lifecycle (10.89s) === RUN TestAccObsBucket_website --- PASS: TestAccObsBucket_website (10.43s) === RUN TestAccObsBucket_cors --- PASS: TestAccObsBucket_cors (10.37s) PASS Process finished with exit code 0 Bucket object: === RUN TestAccObsBucketObject_source --- PASS: TestAccObsBucketObject_source (19.73s) === RUN TestAccObsBucketObject_content --- PASS: TestAccObsBucketObject_content (11.54s) PASS Process finished with exit code 0 W/ AK/SK Bucket: === RUN TestAccObsBucket_basic --- PASS: TestAccObsBucket_basic (54.21s) === RUN TestAccObsBucket_tags --- PASS: TestAccObsBucket_tags (21.75s) === RUN TestAccObsBucket_versioning --- PASS: TestAccObsBucket_versioning (44.25s) === RUN TestAccObsBucket_logging --- PASS: TestAccObsBucket_logging (29.93s) === RUN TestAccObsBucket_lifecycle --- PASS: TestAccObsBucket_lifecycle (55.16s) === RUN TestAccObsBucket_website --- PASS: TestAccObsBucket_website (28.94s) === RUN TestAccObsBucket_cors --- PASS: TestAccObsBucket_cors (32.77s) PASS Process finished with exit code 0 Object: === RUN TestAccObsBucketObject_source --- PASS: TestAccObsBucketObject_source (42.59s) === RUN TestAccObsBucketObject_content --- PASS: TestAccObsBucketObject_content (22.90s) PASS Process finished with exit code 0 Reviewed-by: None <None> Reviewed-by: Rodion Gyrbu <fpsoff@outlook.com> Reviewed-by: Anton Sidelnikov <None>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
If no AK/SK is provided, issue a temporary one.
This affects following resources:
opentelekomcloud_obs_bucketopentelekomcloud_obs_bucket_objectFix #713: Temporary AK/SK is tested (in opentelekomcloud/gophertelekomcloud#53) to work with the agency auth
PR Checklist
Acceptance Steps Performed
Bucket
Object