Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCE] Fix crash on empty basic addon values #836

Merged
merged 1 commit into from
Feb 9, 2021
Merged

[CCE] Fix crash on empty basic addon values #836

merged 1 commit into from
Feb 9, 2021

Conversation

outcatcher
Copy link
Contributor

@outcatcher outcatcher commented Feb 9, 2021 •
edited
Loading

Summary of the Pull Request

Improve handling of addon values (both basic and custom)
Fix #834

Depends-on: #838

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccCCEAddonV3_basic
--- PASS: TestAccCCEAddonV3_basic (503.35s)
=== RUN   TestAccCCEAddonV3_emptyBasic
--- PASS: TestAccCCEAddonV3_emptyBasic (419.24s)
PASS

Process finished with exit code 0

@outcatcher
Fix crash on empty basic addon values
f275213 
Improve handling of addon values (both `basic` and `custom`)
@outcatcher outcatcher added the bug label Feb 9, 2021
@outcatcher outcatcher requested review from a team, lego963 and anton-sidelnikov and removed request for a team February 9, 2021 09:20
@outcatcher

This comment has been minimized.

Sign in to view
@outcatcher outcatcher added the gate Merge PR label Feb 9, 2021
@otc-zuul
Copy link

otc-zuul bot commented Feb 9, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 60bfdea into master Feb 9, 2021
@otc-zuul otc-zuul bot deleted the fix/cce-addon-values branch February 9, 2021 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lego963 lego963 lego963 approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov Awaiting requested review from anton-sidelnikov

Assignees
No one assigned
Labels
bug gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty map in values basic in opentelekomcloud_cce_addon_v3 crash provider
2 participants
@outcatcher @lego963