Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ECS] Refactoring tags workflow #919

Merged
merged 5 commits into from
Mar 19, 2021
Merged

[ECS] Refactoring tags workflow #919

merged 5 commits into from
Mar 19, 2021

Conversation

lego963
Copy link
Contributor

@lego963 lego963 commented Mar 19, 2021 •
edited
Loading

Summary of the Pull Request

Unify usage of tags in resource/opentelekomcloud_ecs_instance_v1

Add validation func in tagsSchema()

PR Checklist

Acceptance Steps Performed

=== RUN   TestAccEcsV1Instance_basic
--- PASS: TestAccEcsV1Instance_basic (179.27s)
=== RUN   TestAccEcsV1Instance_diskTypeValidation
--- PASS: TestAccEcsV1Instance_diskTypeValidation (10.91s)
=== RUN   TestAccEcsV1Instance_VPCValidation
--- PASS: TestAccEcsV1Instance_VPCValidation (175.35s)
PASS

Process finished with exit code 0

@lego963 lego963 requested review from a team, outcatcher and anton-sidelnikov and removed request for a team March 19, 2021 10:07
otc-zuul[bot]
otc-zuul bot previously approved these changes Mar 19, 2021
View reviewed changes
outcatcher
outcatcher suggested changes Mar 19, 2021
View reviewed changes
opentelekomcloud/common/tags.go Outdated
Optional: true,
Type: schema.TypeMap,
Optional: true,
ValidateFunc: ValidateECSTagValue,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is common TagSchema, it shouldn't use ValidateECSTagValue

Copy link
Contributor Author

@lego963 lego963 Mar 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted it

@lego963 lego963 requested a review from outcatcher March 19, 2021 11:22
otc-zuul[bot]
otc-zuul bot previously approved these changes Mar 19, 2021
View reviewed changes
@lego963
Minor tags validation changes
636bfd5 
Update pattern

Add checks for len()
@lego963 lego963 added the gate Merge PR label Mar 19, 2021
@lego963 lego963 mentioned this pull request Mar 19, 2021
Closed
3 tasks
@otc-zuul
Copy link

otc-zuul bot commented Mar 19, 2021

Build succeeded.

@otc-zuul otc-zuul bot merged commit 44fa909 into devel Mar 19, 2021
@otc-zuul otc-zuul bot deleted the ecsv1-unify-tags branch March 19, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outcatcher outcatcher outcatcher approved these changes

@otc-zuul otc-zuul otc-zuul approved these changes

@anton-sidelnikov anton-sidelnikov anton-sidelnikov approved these changes

Assignees
No one assigned
Labels
documentation gate Merge PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lego963 @outcatcher @anton-sidelnikov