Why is TracingHandlerInterceptor conditional on missing TracingFilter?

[whiskeysierra]

Code in question:

java-spring-web/opentracing-spring-web-starter/src/main/java/io/opentracing/contrib/spring/web/starter/ServerTracingAutoConfiguration.java

Lines 100 to 102 in 8b802ba

	@Bean
	@ConditionalOnMissingBean(TracingFilter.class)
	public WebMvcConfigurer tracingHandlerInterceptor(final Tracer tracer) {

The source code of TracingHandlerInterceptor seems to suggest that it's meant to be used in conjunction with the TracingFilter:

java-spring-web/opentracing-spring-web/src/main/java/io/opentracing/contrib/spring/web/interceptor/TracingHandlerInterceptor.java

Line 90 in 6966272

* 1. check if there is an active span, it has been activated in servlet filter or in this interceptor (forward)

[geoand]

@pavolloffay do you remember? I think you added that piece of code.

[pavolloffay]

Based on git blame #39

[whiskeysierra]

That pull request doesn't really explain why though.

…

On Fri, 29 Nov 2019, 18:20 Pavol Loffay, ***@***.***> wrote: Based on git blame #39 <#39> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#120?email_source=notifications&email_token=AADI7HNHFLLROQHDNQUJ36TQWFFPDA5CNFSM4JSHVW3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPJ7MA#issuecomment-559849392>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADI7HPFJRSRKCGMXZS26BLQWFFPDANCNFSM4JSHVW3A> .