Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec] Identity operation #26718

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

PiotrKrzem
Copy link
Contributor

@PiotrKrzem PiotrKrzem commented Sep 20, 2024

Details:

Question for review - is "activation" the correct folder to place this op into, or would "internal" be better?

Tickets:

  • 152730

@github-actions github-actions bot added category: Core OpenVINO Core (aka ngraph) category: IE Tests OpenVINO Test: plugins and common category: Python API OpenVINO Python bindings category: docs OpenVINO documentation category: TEMPLATE OpenVINO Template plugin category: CPP API OpenVINO CPP API bindings labels Sep 20, 2024

**Category**: *Matrix*

**Short description**: *Identity* operation forwards the input as the output, essentially computing the4 linear activation function f(x) = x.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
**Short description**: *Identity* operation forwards the input as the output, essentially computing the4 linear activation function f(x) = x.
**Short description**: *Identity* operation forwards the input as the output, essentially computing the linear activation function f(x) = x.


**Detailed description**: *Identity* operation either directly outputs the input, or returns a new Tensor with the same shape, data type and data as the input.

This behavior is targeted to mimic the design of PyTorch and Tensorflow frameworks. PyTorch by design returns the reference of the input, whereas Tensorflow creates a copy of the input.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This behavior is targeted to mimic the design of PyTorch and Tensorflow frameworks. PyTorch by design returns the reference of the input, whereas Tensorflow creates a copy of the input.
This behavior is targeted to mimic the design of PyTorch and TensorFlow frameworks. PyTorch by design returns the reference of the input, whereas TensorFlow creates a copy of the input.

@@ -251,6 +251,29 @@ def bitwise_left_shift(
)


@nameable_op
def bitwise_right_shift(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def bitwise_right_shift(
def identity(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph) category: CPP API OpenVINO CPP API bindings category: docs OpenVINO documentation category: IE Tests OpenVINO Test: plugins and common category: Python API OpenVINO Python bindings category: TEMPLATE OpenVINO Template plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants