-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Identity operation #26718
Draft
PiotrKrzem
wants to merge
5
commits into
openvinotoolkit:master
Choose a base branch
from
PiotrKrzem:feature/spec_identity
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[Spec] Identity operation #26718
PiotrKrzem
wants to merge
5
commits into
openvinotoolkit:master
from
PiotrKrzem:feature/spec_identity
+737
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
category: Core
OpenVINO Core (aka ngraph)
category: IE Tests
OpenVINO Test: plugins and common
category: Python API
OpenVINO Python bindings
category: docs
OpenVINO documentation
category: TEMPLATE
OpenVINO Template plugin
category: CPP API
OpenVINO CPP API bindings
labels
Sep 20, 2024
rkazants
reviewed
Sep 21, 2024
|
||
**Category**: *Matrix* | ||
|
||
**Short description**: *Identity* operation forwards the input as the output, essentially computing the4 linear activation function f(x) = x. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
**Short description**: *Identity* operation forwards the input as the output, essentially computing the4 linear activation function f(x) = x. | |
**Short description**: *Identity* operation forwards the input as the output, essentially computing the linear activation function f(x) = x. |
rkazants
reviewed
Sep 21, 2024
|
||
**Detailed description**: *Identity* operation either directly outputs the input, or returns a new Tensor with the same shape, data type and data as the input. | ||
|
||
This behavior is targeted to mimic the design of PyTorch and Tensorflow frameworks. PyTorch by design returns the reference of the input, whereas Tensorflow creates a copy of the input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
This behavior is targeted to mimic the design of PyTorch and Tensorflow frameworks. PyTorch by design returns the reference of the input, whereas Tensorflow creates a copy of the input. | |
This behavior is targeted to mimic the design of PyTorch and TensorFlow frameworks. PyTorch by design returns the reference of the input, whereas TensorFlow creates a copy of the input. |
rkazants
reviewed
Sep 21, 2024
@@ -251,6 +251,29 @@ def bitwise_left_shift( | |||
) | |||
|
|||
|
|||
@nameable_op | |||
def bitwise_right_shift( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
def bitwise_right_shift( | |
def identity( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Core
OpenVINO Core (aka ngraph)
category: CPP API
OpenVINO CPP API bindings
category: docs
OpenVINO documentation
category: IE Tests
OpenVINO Test: plugins and common
category: Python API
OpenVINO Python bindings
category: TEMPLATE
OpenVINO Template plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Question for review - is "activation" the correct folder to place this op into, or would "internal" be better?
Tickets: