[fix] Reduce max zoom level to prevent unintended behavior due to exc… #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essive zooming openwisp#188 Related to openwisp#188
|
@nemesifier please review it. |
nemesifier
requested changes
Apr 6, 2024
There was a problem hiding this comment.
@d1vyanshu-kumar no need to close and reopen the PR, just force push next time.
It doesn't seem to me that any parameter you are adding here is configurable by the user, why hardcoding arbitrary settings in a library which is designed to be flexible?
| @@ -44,6 +48,7 @@ export default function extendLeafletModel(echarts) { | |||
| }, | |||
| ], | |||
| layerControl: {}, | |||
|
|
|||
…essive zooming openwisp#188 Related to openwisp#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the max zoom level to mitigate excessive zooming behaviour. Set zoom sensitivity and max zoom value from 32 to 15.
zoom.mov