node: fix host build fail #6015
Conversation
|
@nxhack I tested this patch on both Ubuntu and Arch, both normal and travis builds and there were no failures. Travis fail might have been caused by DNS issues with git.openwrt.org at the time you created the pull request. This also fixes error "invalid conversion from" in node_crypto.cc that I was having last 2 days. (host-compile phase) Try to refresh the pull request and it might pass this time, if it does not timeout... |
|
Since travis CI uses the ar71xx SDK, node.js is out of build target. (FPU issue) |
|
@nxhack i did try builing localy using Travis build scripts and openwrt-sdk-ar71xx-generic_gcc-7.3.0_musl.Linux-x86_64 toolchain that it uses by default. I did so by running the same scripts that Travis does (inside the packages feed): I doubt that Travis does anything more than this, but correct me if i am wrong, i would like to understand the whole process. Node package also has a mips check. And it compiles with "--with-mips-float-abi=soft" so there should be no failures. Note that you can modify the .travis_do.sh script and add V=s to build. This is disabled because Travis server can't handle all of the output. |
|
Tnx nxhack. Anyone against merging this? |
|
Hi, @nxhack , if it's related to systemtap or dtrace, can we just disable it with |
lang/node/Makefile
Outdated
| @@ -129,6 +129,7 @@ HOST_CONFIGURE_ARGS:= \ | |||
| --dest-os=linux \ | |||
| --without-snapshot \ | |||
| --shared-zlib \ | |||
| --systemtap-includes=$(HOST_BUILD_DIR)/deps/openssl/openssl/include \ | |||
There was a problem hiding this comment.
The configure option should really be --shared-openssl-includes?
There was a problem hiding this comment.
In node.js' host build we use bundle openssl instead of shared openssl.
Specifying "--shared-openssl-includes” option is ineffective useing bundle openssl.
Host build of node.js now fails after the version of libressl updated on current openwrt.
In order to avoid it, I used a dirty method.
There was a problem hiding this comment.
@nxhack , please document the intent either in the commit message or properly in the Makefile. Thank you.
There was a problem hiding this comment.
As you point out, it is a confusing, bad workaround.
-
When building bundles openssl of node.js, it fails by referring to the header of libressl.
-
"configure script" of node.js generates config.gyp.
'include_dirs': [ '/home/ubuntu/Trunk/openwrt/staging_dir/host/include'],
'libraries': [ '-L/home/ubuntu/Trunk/openwrt/staging_dir/host/lib',
'-lz']},
I want to change include_dirs.
I will think again whether there is a good hack.
There was a problem hiding this comment.
OK I found, pkg-config was set to build shared zlib. As a workaround, I will change zlib to use bundle version as well.
modify patch. nodejs/node#19196 made not to use libressl headers fix to include path not to use "host/include" Signed-off-by: Hirokazu MORIKAWA <morikw2@gmail.com>
|
It became a simple hack. ;) |
|
Thank you for the time and efforts! |
Maintainer: @blogic , @ianchi and @ratkaj
Compile tested: ar71xx, LEDE trunk r6835-e495a05 (w fpu emu)
Run tested: NONE
Description:
fix host build failure and made not to use libressl headers
nodejs/node#19196
#5734
Signed-off-by: Hirokazu MORIKAWA morikw2@gmail.com