improve: use fixed thread pool explicitly #2265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysymi
reviewed
Mar 7, 2024
| @@ -191,13 +200,11 @@ default Metrics getMetrics() { | |||
| } | |||
|
|
|||
| default ExecutorService getExecutorService() { | |||
| return newThreadPoolExecutor(minConcurrentReconciliationThreads(), | |||
| concurrentReconciliationThreads()); | |||
| return Executors.newFixedThreadPool(DEFAULT_RECONCILIATION_THREADS_NUMBER); | |||
There was a problem hiding this comment.
current approach is safe enough. If user want to get better startup performance, they can increase reconciliation thread number or override getExecutorService method
There was a problem hiding this comment.
Hi @ysymi , using now the method to get the thread number instead of the static variable if you mean that.
Note that it was confusing that the concurrentReconciliationThreads() was ignored until now; the minConcurrentReconciliationThreads() was the size of a fixed thread pool at the end.
Signed-off-by: Attila Mészáros <csviri@gmail.com>
Signed-off-by: Attila Mészáros <csviri@gmail.com>
csviri
force-pushed
the
use-fixed-threadpool
branch
from
1e9aaa2
to
5f6156f
Compare
Signed-off-by: Chris Laprun <claprun@redhat.com>
metacosm
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that it was a fixed thread pool also now, just it was confusing with min and max values,