set packageserver replicas to 1 for single node #2062
Conversation
ankitathomas
force-pushed
the
single-node-packageserver
branch
from
43e39e8
to
da0f127
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ankitathomas, kevinrizza The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
| @@ -70,7 +70,7 @@ spec: | |||
| spec: | |||
| strategy: | |||
| type: RollingUpdate | |||
| replicas: 2 | |||
| replicas: 1 | |||
There was a problem hiding this comment.
actually, we probably don't want to update this existing released manifest. It'll just get updated in the next release.
There was a problem hiding this comment.
+1, the same goes for the change to deploy/ocp/manifests/0.17.0/0000_50_olm_15-packageserver.clusterserviceversion.yaml.
There was a problem hiding this comment.
Ok, I've reverted the changes on the released manifests. The quickstart manifest is still using single replica packageserver.
There was a problem hiding this comment.
Wait, hold on, I think we do need this change to land in the downstream manifests/ directory (unless we want to only make that change in the downstream repo?), we just don't want it to land in any of the /0.17.0 release directories because those releases are already, well, released.
There was a problem hiding this comment.
So we want to update replicas in the ocp manifests then?
ankitathomas
force-pushed
the
single-node-packageserver
branch
2 times, most recently
from
4a59638
to
32d5ba1
Compare
Signed-off-by: Ankita Thomas <ankithom@redhat.com>
|
/retest |
|
/lgtm |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
The single-node topology should allow only a single instance of the package server. The 1 replica default was to avoid fatal discovery errors for the packageserver api, which have been updated to non-fatal errors as of kubernetes/kubernetes#73035.
Reverting the default packageserver replicas to 1