Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reconcile-period and default value #5565

Closed
jfgosselin opened this issue Feb 23, 2022 · 1 comment · Fixed by #5585
Closed

reconcile-period and default value #5565

jfgosselin opened this issue Feb 23, 2022 · 1 comment · Fixed by #5585
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. language/helm Issue is related to a Helm operator project
Milestone

Comments

@jfgosselin
Copy link

What is the URL of the document?

(https://sdk.operatorframework.io/docs/building-operators/helm/)

Which section(s) is the issue in?

Reference for Helm-based Operators

What needs fixing?

For the Helm-based Operators you can pass the parameter --reconcile-period but what's the default value ?

Is there a way to set it per CR in the watches.yaml like Ansible ?

Additional context

@jfgosselin jfgosselin added the kind/documentation Categorizes issue or PR as related to documentation. label Feb 23, 2022
@VenkatRamaraju
Copy link
Contributor

VenkatRamaraju commented Feb 24, 2022

Hey @jfgosselin,

Thanks for bringing this up.

The default value for the --reconcile-period flag is 1m, as indicated here. One way to specify the reconcile period outside of the command line flag (similar to ansible) would be in the CR's annotations like:

metadata:
  name: nginx-sample
  annotations:
    helm.sdk.operatorframework.io/reconcile-period: 5s

However, I realized we are currently ignoring this value that is set in the custom resource's annotations. It's definitely something we should fix, along with adding the relevant documentation. I'll take this up soon.

@jmrodri jmrodri added the language/helm Issue is related to a Helm operator project label Mar 7, 2022
@jmrodri jmrodri added this to the v1.19.0 milestone Mar 7, 2022
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 7, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 7, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 7, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 8, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 8, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 9, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 9, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 9, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 9, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 9, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
VenkatRamaraju pushed a commit to VenkatRamaraju/operator-sdk that referenced this issue Mar 10, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
jmrodri pushed a commit that referenced this issue Mar 11, 2022
Signed-off-by: Venkat Ramaraju <vramaraj@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. language/helm Issue is related to a Helm operator project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants