Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pillow requirements #38

Merged
merged 2 commits into from
Jul 8, 2021
Merged

Remove pillow requirements #38

merged 2 commits into from
Jul 8, 2021

Conversation

Crissman
Copy link
Contributor

@Crissman Crissman commented Jul 7, 2021

Motivation

Pillow 8.3.1 has been released, which fixes the numpy incompatibility which was causing errors for the multi-objective and fast.ai examples.
python-pillow/Pillow#5578
Basically, a rollback of #36 .

Description of the changes

Remove the pillow requirements to avoid 8.3.0.

@Crissman Crissman marked this pull request as draft July 7, 2021 09:49
@nzw0301
Copy link
Member

nzw0301 commented Jul 7, 2021

I reported the error to the FastAI repo fastai/fastai#3416 (comment).

@nzw0301 nzw0301 self-assigned this Jul 7, 2021
@Crissman Crissman marked this pull request as ready for review July 8, 2021 09:16
@Crissman
Copy link
Contributor Author

Crissman commented Jul 8, 2021

Ok, made half a roll-back and added the error report. Please merge if the tests pass! 🙇

Copy link
Member

@nzw0301 nzw0301 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@nzw0301 nzw0301 merged commit 8480b58 into optuna:main Jul 8, 2021
@nzw0301 nzw0301 added this to the v2.9.0 milestone Aug 2, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants