Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the User Email field to the List #2178

Merged
merged 2 commits into from
May 5, 2022
Merged

Added the User Email field to the List #2178

merged 2 commits into from
May 5, 2022

Conversation

leigh-pointer
Copy link
Contributor

Added the formatted email address of the user to the list view.

Added the formatted email address of the user to the list view.
@sbwalker
Copy link
Member

sbwalker commented May 5, 2022

@leigh-pointer I like this improvement - however the more columns that are added to the main User view, the more the mobile experience gets degraded as there is too much information to display horizontally without a lot of scrolling. This is the reason why most of the main admin view components in Oqtane have minimal columns - and Edit will display the details in a vertical orientation where it is easier to navigate. This will become even more important once Oqtane runs in MAUI and there will be native mobile app users. If we add email to the main view perhaps some of the other fields should be removed? What information is absolutely needed 90% of the time... and what information is better to include in the Edit view?

@leigh-pointer
Copy link
Contributor Author

@sbwalker I agree. Maybe remove the name field, as it references are mostly by username and also reduce the DateTime formats and remove the seconds.

Removed Name
Removed Seconds from DateTime fields
Added Name to the Email link
@sbwalker
Copy link
Member

sbwalker commented May 5, 2022

@leigh-pointer you are correct that most user-facing references to User use DisplayName and most admin-facing references use Username (ie. AuditControl) - so displaying Username and Email make sense. Perhaps we remove LastIPAddress and CreatedBy from the main view as I am questioning how often this information is used?

@sbwalker sbwalker merged commit c15f2b9 into oqtane:dev May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants