Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed invalid descriptions on root definitions in rtp.json #65

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexander-applyinnovations
Copy link

@alexander-applyinnovations alexander-applyinnovations commented Oct 25, 2023

The current definition of the updated docs contains two lines that do not satisfy the validation requirements for open-api spec.

This PR amends the rtp api spec to remove the invalid description fields in order to generate sdks using the openapi sdk generator.

Here are the relevant error logs:

Exception in thread "main" org.openapitools.codegen.SpecValidationException: There were issues with the specification. The option can be disabled via validateSpec (Maven/Gradle) or --skip-validate-spec (CLI).
 | Error count: 2, Warning count: 0
Errors: 
        -attribute definitions.rateCodes.description is unexpected
        -attribute definitions.roomTypes.description is unexpected

        at org.openapitools.codegen.config.CodegenConfigurator.toContext(CodegenConfigurator.java:620)
        at org.openapitools.codegen.config.CodegenConfigurator.toClientOptInput(CodegenConfigurator.java:647)
        at org.openapitools.codegen.cmd.Generate.execute(Generate.java:479)
        at org.openapitools.codegen.cmd.OpenApiGeneratorCommand.run(OpenApiGeneratorCommand.java:32)
        at org.openapitools.codegen.OpenAPIGenerator.main(OpenAPIGenerator.java:66)

GitHub actions log for applyinnovations/ohip-sdk respository
https://github.com/applyinnovations/ohip-sdk/actions/runs/6634049598/job/18022861256

@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 25, 2023
@alexander-applyinnovations
Copy link
Author

@rb80 Please review this for merge into your existing PR to main

@oracle-contributor-agreement
Copy link

Thank you for signing the OCA.

@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 25, 2023
@spavlusieva spavlusieva requested a review from rb80 October 25, 2023 07:45
@rb80
Copy link
Member

rb80 commented Oct 30, 2023

@alexander-applyinnovations , I think this is resolved with #64 which among other things includes the removal of unicode from specs. If you agree could you close this PR?

@alexander-applyinnovations
Copy link
Author

alexander-applyinnovations commented Nov 1, 2023

@rb80 thanks for merging the new docs into main, however the same issues exist in main as did in oracle:property_23.2

See the affected lines here and here

@alexander-applyinnovations alexander-applyinnovations changed the base branch from property_23.2 to main November 1, 2023 11:41
@alexander-applyinnovations
Copy link
Author

@rb80 could you please consider merging this PR or please specify why this can't be done?

Thanks!
Alex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants