Add version-related keys to RbConfig::CONFIG #3664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
andrykonchin
approved these changes
Sep 13, 2024
eregon
reviewed
Sep 13, 2024
There was a problem hiding this comment.
Thank you for the PR!
It raises some tricky questions about what some of these values should be.
I shared my thoughts there, if you agree please change them.
If not, that's fine too.
In any case it seems better to have these set than not at all for compatibility.
For critical stuff like ABI version RbConfig::CONFIG['ruby_version'] should already be used (and is by RubyGems & Bundler, etc).
|
I agree, I'm not sure what they are all precisely supposed to represent, but for compatibility it seems best to have something. |
rwstauner
force-pushed
the
rwstauner/rbconfig-version
branch
from
e626322
to
7367c2c
Compare
eregon
approved these changes
Sep 13, 2024
andrykonchin
added
the
in-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some of the entries mentioned in #3396
that
rb-syslooks for:https://github.com/oxidize-rb/rb-sys/blob/086d3a2a2992b66c4b84eacad7c7a92bf67725b5/crates/rb-sys-build/src/rb_config.rs#L344-L346
https://github.com/oxidize-rb/rb-sys/blob/086d3a2a2992b66c4b84eacad7c7a92bf67725b5/crates/rb-sys-build/src/rb_config.rs#L183
https://github.com/oxidize-rb/rb-sys/blob/086d3a2a2992b66c4b84eacad7c7a92bf67725b5/crates/rb-sys/build/main.rs#L123