Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GR-45043] Update Prism to 1.0.0 #3669

Closed
wants to merge 7 commits into from
Closed

Conversation

graalvmbot
Copy link
Collaborator

No description provided.

The following fields were renamed:
- CaseMatchNode#consequent was renamed to CaseMatchNode#else_clause
- CaseNode#consequent was renamed to CaseNode#else_clause
- IfNode#consequent was renamed to IfNode#subsequent
- RescueNode#consequent was renamed to RescueNode#subsequent
- UnlessNode#consequent was renamed to UnlessNode#else_clause
See https://github.com/ruby/prism/releases/tag/v1.0.0
It's documented in the following way:
```
* Whether or not the encoding magic comments should be respected. This is a
* niche use-case where you want to parse a file with a specific encoding
* but ignore any encoding magic comments at the top of the file.
```

So passing `true` disabled detecting encoding magic comments in parsed source code.
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 16, 2024
The node wad already introduced but wasn't used by parser. Now Prism generates this node for constant assignment in files with #` shareable_constant_value: literal` magic comment.
There is only one such comment - in lib/mri/time.rb file
`startOffset` and `length` constructor parameters were moved to the beginning of parameters list
Warning - '...lib/truffle/stringio.rb:137: warning: possibly useless use of self in void context'
@graalvmbot graalvmbot closed this Sep 16, 2024
@graalvmbot graalvmbot deleted the ak/update-prism-to-1-0-0 branch September 16, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants