Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: format using Make #62

Merged
merged 10 commits into from
Sep 22, 2022
Merged

chore: format using Make #62

merged 10 commits into from
Sep 22, 2022

Conversation

kevgo
Copy link
Contributor

@kevgo kevgo commented Sep 16, 2022

Addresses parts of https://github.com/ory-corp/general/issues/735.

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation within the code base (if appropriate).

@kevgo
Copy link
Contributor Author

kevgo commented Sep 16, 2022

Docker scanner failures seem unrelated to these changes, possibly because this PR is from an external fork.

@Demonsthere
Copy link
Collaborator

The CI is failing due to CVE errors in the base images (older docker). I would need to bump the images first 😞

@kevgo
Copy link
Contributor Author

kevgo commented Sep 22, 2022

@Demonsthere I leave it up to you to bump the Docker image versions at your own schedule. I'll be merging this in for now. CI tests are broken nonetheless. Thanks for your review!

@kevgo kevgo merged commit 6b1b22b into ory:master Sep 22, 2022
@kevgo kevgo deleted the kg-format-makefile branch September 22, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants