chore: added mocked adapters #25
Conversation
| @@ -0,0 +1,18 @@ | |||
| // import { | |||
| export * from './default-checkout.adapter'; | ||
| export * from './normalizers'; | ||
| export * from './serializers'; | ||
| export * from './spryker-glue'; |
There was a problem hiding this comment.
Why Spryker Glue is the default here? Shouldn't that be the mocks?
| @@ -0,0 +1,308 @@ | |||
| import { PlaceOrderData } from '@spryker-oryx/checkout'; | |||
There was a problem hiding this comment.
Could you please add a comment at the top on how to use these files.
Smth like "to be replaced with a backend system API"
| @@ -1,2 +1,2 @@ | |||
| export * from './default-product-relations-list.adapter'; | |||
| export * from './glue-product-relations-list.adapter'; | |||
There was a problem hiding this comment.
should that be spryker-glue?
| DefaultSuggestionRendererService, | ||
| FacetColorsMapping, | ||
| FacetListService, | ||
| productSuggestionRenderer, | ||
| GlueSuggestionAdapter, |
There was a problem hiding this comment.
Should these plugins be SprykerGlue...?
| @@ -3,7 +3,7 @@ import { createInjector, destroyInjector, getInjector } from '@spryker-oryx/di'; | |||
| import { MessageType, postMessage } from '@spryker-oryx/experience'; | |||
| import { RouteType } from '@spryker-oryx/router'; | |||
| import { of } from 'rxjs'; | |||
| import { SuggestionField } from '../adapter'; | |||
| import { SuggestionField } from '../adapter/spryker-glue'; | |||
There was a problem hiding this comment.
Is there a way to define the path for all of these imparts? all at once?
Typically you will have one set of adapters used everywhere. Cases where I need to specify a separate import directory when multiple vendors involved are limited, and then it can be a little more complex to do. But per default it should be a one-time switcher.
| export const StoreNormalizer = 'oryx.StoreNormalizer*'; | ||
|
|
||
| export function storeAttributesNormalizer(data: DeserializedStores): Store[] { | ||
| // TODO: drop this when the backend is healthy again; current dynamic |
There was a problem hiding this comment.
A lot of work, thanks @tolerants ! 👏
We need to sill settle on the naming and keep it consistent.
Also we need to check if we can make a step forward to new developers, avoiding per component mock/custom definition (of possible). Additionally please merge master and fix CI.
No description provided.