Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Moved SCOS_BASE_URL from secrets to vars #50

Closed
wants to merge 1 commit into from
Closed

ci: Moved SCOS_BASE_URL from secrets to vars #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
GIT_USER: ${{ vars.GIT_USER }}
GIT_EMAIL: ${{ vars.GIT_EMAIL }}
RELEASE_BRANCH: ${{ github.event.workflow_run.head_branch || github.ref }}
SCOS_BASE_URL: ${{ secrets.SCOS_BASE_URL }}
SCOS_BASE_URL: ${{ vars.SCOS_BASE_URL }}
FES_CONTENT_BACKEND_URL: ${{ secrets.FES_CONTENT_BACKEND_URL }}
STORE: ${{ vars.STORE }}
ORYX_FEATURE_VERSION: latest
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,8 +114,8 @@ jobs:
id: set-env
run: |
echo "CHROMATIC_PROJECT_TOKEN=${{ secrets.CHROMATIC_PROJECT_TOKEN }}"
echo "SCOS_BASE_URL=${{ secrets.SCOS_BASE_URL }}"
if [ -n "${{ secrets.SCOS_BASE_URL }}" ]; then
echo "SCOS_BASE_URL=${{ vars.SCOS_BASE_URL }}"
if [ -n "${{ vars.SCOS_BASE_URL }}" ]; then
echo "::set-output name=should-run-regression::true"
else
echo "::set-output name=should-run-regression::false"
Expand Down Expand Up @@ -184,7 +184,7 @@ jobs:
- name: Storefront E2E Tests
uses: ./.github/actions/run-optimal
env:
SCOS_BASE_URL: ${{ secrets.SCOS_BASE_URL }}
SCOS_BASE_URL: ${{ vars.SCOS_BASE_URL }}
CYPRESS_RECORD_KEY: ${{ secrets.CYPRESS_RECORD_KEY }}
STORE: DE
ORYX_FEATURE_VERSION: latest
Expand All @@ -207,7 +207,7 @@ jobs:
- name: Storefront B2C visual regression tests
uses: ./.github/actions/run-optimal
env:
SCOS_BASE_URL: ${{ secrets.SCOS_BASE_URL }}
SCOS_BASE_URL: ${{ vars.SCOS_BASE_URL }}
STORE: DE
ORYX_FEATURE_VERSION: latest
PERCY_TOKEN: ${{ secrets.PERCY_TOKEN }}
Expand Down
Loading