Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose up and docker build work again #8

Closed
wants to merge 1 commit into from

Conversation

ramontayag
Copy link
Contributor

  • VERSION in Dockerfile defaults to 3.1.1 if not specified

VERSION defaults to 3.1.1 if not specified.
@ramontayag ramontayag mentioned this pull request Mar 28, 2018
1 task
@ramontayag
Copy link
Contributor Author

@osminogin - just continuing the conversation here for #4 (comment)

Without it, we won't be able to use docker-compose to build.

@osminogin
Copy link
Owner

This docker-compose.yml is just demonstration in that case. So if it is misleading, then it is better to delete it altogether.

@osminogin
Copy link
Owner

osminogin commented Apr 7, 2018

Or I think is best and right solution for this is just remove build: . and replace with image: osminogin/electrum-daemon
You get all working as needed without any hardcode.

@osminogin osminogin closed this Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants