Puneet/epochevents #2515
Merged
Puneet/epochevents #2515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2022
ValarDragon
approved these changes
Aug 26, 2022
ValarDragon
added
A:backport/v10.x
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
* add events from cachectx to main ctx events * add tests for events from hooks. * add entry to CHANGELOG.md (cherry picked from commit 1b5e970) # Conflicts: # CHANGELOG.md
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2022
* add events from cachectx to main ctx events * add tests for events from hooks. * add entry to CHANGELOG.md (cherry picked from commit 1b5e970) # Conflicts: # CHANGELOG.md
ValarDragon
added a commit
that referenced
this pull request
Aug 26, 2022
* Puneet/epochevents (#2515) * add events from cachectx to main ctx events * add tests for events from hooks. * add entry to CHANGELOG.md (cherry picked from commit 1b5e970) # Conflicts: # CHANGELOG.md * Fix conflict Co-authored-by: Puneet <59960662+puneet2019@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
ValarDragon
added a commit
that referenced
this pull request
Aug 26, 2022
* Puneet/epochevents (#2515) * add events from cachectx to main ctx events * add tests for events from hooks. * add entry to CHANGELOG.md (cherry picked from commit 1b5e970) # Conflicts: # CHANGELOG.md * Fix changelog Co-authored-by: Puneet <59960662+puneet2019@users.noreply.github.com> Co-authored-by: Dev Ojha <dojha@berkeley.edu>
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
panicCatchingEpochHookdoes not append events happening in modules implementing the hooksctx.EventManager().EmitEvents(cacheCtx.EventManager().Events())Brief Changelog
<--! (for example:) -->
func panicCatchingEpochHooknow emits the events that are part ofcacheCtxTesting and Verifying
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no) - yesx/<module>/spec/) / Osmosis docs repo / not documented) - not documented