[Incentives Module][bugfix] Scale gas costs by denoms in gauge #4830
Conversation
stackman27
added
V:state/compatible/backport
| sdk.NewCoin("atom", sdk.NewInt(99999)), | ||
| ), | ||
| gaugeId: 1, | ||
| minimumGasConsumed: uint64(2 * types.BaseGasFeeForAddRewardToGauge), |
There was a problem hiding this comment.
Since the base gas cost for txns like these are usually in the 10k-20k gas range, we should add a test case with many denoms (>4) to ensure that the minimumGasConsumed check isn't passing trivially
There was a problem hiding this comment.
sounds good added! for 8 tokens it looks like this;
gasConsumed: 161441 tc. minimumGasConsumed: 80000
x/incentives/keeper/gauge.go
Outdated
| @@ -152,6 +152,10 @@ func (k Keeper) AddToGaugeRewards(ctx sdk.Context, owner sdk.AccAddress, coins s | |||
| if gauge.IsFinishedGauge(ctx.BlockTime()) { | |||
| return errors.New("gauge is already completed") | |||
| } | |||
|
|
|||
| // Fixed gas consumption adding reward to gauges based on the number of coins to add | |||
| ctx.GasMeter().ConsumeGas(uint64(types.BaseGasFeeForAddRewardToGauge*len(coins)), "scaling gas cost for adding to gauge rewards") | |||
There was a problem hiding this comment.
Just realized that this should actually be charging baseAmount * (len(gauge.Coins) + len(coins)) since we allow for adding multiple coins at once here. The current implementation only scales by the number of coins being added, not the ones that already exist.
There was a problem hiding this comment.
i see, i originally thought it was just for new denoms. I'll change it to accomodate existing denoms
Re
gasConsumed: 171474 minimumGasConsumed: 80000
|
@stackman27 please add a CHANGELOG entry prior to merge |
added! |
Closes: #4738
What is the purpose of the change
Similarly to what we did for incentive records in CL, we should be scaling gas costs for adding to gauges to prevent spam, as distribution logic linearly iterates over all denoms in a gauge at epoch.
Add scaling gas costs to AddToGaugeRewards, similar to how we did it for incentive records
Brief Changelog
AddToGaugeRewards, linearly increase with coins to addTesting and Verifying
added new tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)