docs: precision issues around price; short and long term solution #5552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added
the
F: concentrated-liquidity
github-actions
bot
added
C:docs
Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com>
stackman27
reviewed
Jun 16, 2023
Comment on lines
+1675
to
+1681
| Now, we have a problem that we cannot handle pairs where | ||
| the quote asset has a precision of 6 and the base asset has a | ||
| precision of 18. | ||
|
|
||
| Note that this is not a problem for pairs where the quote asset | ||
| has a precision of 18 and the base asset has a precision of 6. | ||
| E.g. OSMO/DAI. |
There was a problem hiding this comment.
i'm trying to understand this a little more
so in the above example,
osmo quote (6th precision) & arb base (18th prevision)
spot price = (218023341414 / 10**6) / (101170077995723619690981 / 10**18)
spot price = 2.1550180224553714
Why would this not work?
There was a problem hiding this comment.
Because in AMM units, this is:
>>> 218023341414 / 101170077995723619690981
2.1550180224553714e-12
It does not account for precision. As a result, we are right at the boundary of the spot price that can be represented without issues
There was a problem hiding this comment.
i see, new min limit is 10^-12.
but why don't we do (quote / precision) / (base / precision) instead of just quote / base, on chain side?
There was a problem hiding this comment.
This is how precisions for these assets were historically defined. So we must normalize them to be in the same units
Co-authored-by: Sishir Giri <sis1001@berkeley.edu>
Co-authored-by: Sishir Giri <sis1001@berkeley.edu>
|
Addressed all comments. R4R |
AlpinYukseloglu
approved these changes
Jun 18, 2023
ValarDragon
reviewed
Jun 19, 2023
ValarDragon
approved these changes
Jun 19, 2023
mattverse
pushed a commit
that referenced
this pull request
Jun 20, 2023
) Closes: #XXX ## What is the purpose of the change Related to: #5550 Documenting latest decisions around tick and price conversions ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - [ ] Does this pull request introduce a new feature or user-facing behavior changes? - [ ] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A
ValarDragon
added a commit
that referenced
this pull request
Jun 20, 2023
* Some optimizations * Update x/concentrated-liquidity/math/math.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * [CL]: Fix incorrect bound check/chain halt vector (#5557) * repro panic trigger and fix bound check * fix comments * docs: precision issues around price; short and long term solution (#5552) Closes: #XXX ## What is the purpose of the change Related to: #5550 Documenting latest decisions around tick and price conversions ## Testing and Verifying This change is a trivial rework / code cleanup without any test coverage. ## Documentation and Release Note - [ ] Does this pull request introduce a new feature or user-facing behavior changes? - [ ] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A * Make go tests only run if relevant (#5569) * CL: migration functional test (#5560) Closes: #XXX ## What is the purpose of the change The following PR introduces a functional test that: - Creates every type of balancer position that can be created - Bonded superfluid - Unbonded superfluid (locked) - Unbonded superfluid (unlocking) - Vanilla lock (locked) - Vanilla lock (unlocking) - No lock - It then migrates each position, asserting invariants after each position is migrated - Finally, an overall invariant is run after all positions have been migrated, asserting that all funds are accounted for in some way The next PR subsequent to this will be adding randomization to the inputs in order to make the test non deterministic. ## Testing and Verifying Functional test above added ## Documentation and Release Note - [ ] Does this pull request introduce a new feature or user-facing behavior changes? - [ ] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A * [CL]: Fix tick rounding bug and implement direct conversion from tick <> sqrt price (#5541) Closes: #5516 > **Note to reviewer:** the only real state machine change is in `tick.go` and heavily mirrors @ValarDragon's PR here: #5522 > The rest of the changes are related to function renames/test refactors. ## What is the purpose of the change This PR expands on #5522 and updates all price to tick conversions to use SqrtPriceToTick instead. ## Testing and Verifying The new function is tested in `math/tick_test.go` The original attack vector is also converted into an edge case test in `position_test.go` ## Documentation and Release Note - [ ] Does this pull request introduce a new feature or user-facing behavior changes? - [ ] Changelog entry added to `Unreleased` section of `CHANGELOG.md`? Where is the change documented? - [ ] Specification (`x/{module}/README.md`) - [ ] Osmosis documentation site - [ ] Code comments? - [ ] N/A * Still fixing merge conlfict * Revert lp.go change as commented --------- Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: alpo <62043214+AlpinYukseloglu@users.noreply.github.com> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: Adam Tucker <adam@osmosis.team>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Related to: #5550
Documenting latest decisions around tick and price conversions
Testing and Verifying
This change is a trivial rework / code cleanup without any test coverage.
Documentation and Release Note
Unreleasedsection ofCHANGELOG.md?Where is the change documented?
x/{module}/README.md)