refactor: arb filter for new authz exec swap #7210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p0mvn
added a commit
that referenced
this pull request
Dec 26, 2023
* refactor: arb filter for new authz exec swap * updates * updates * updates
nicolaslara
reviewed
Dec 26, 2023
| Denom: "ibc/D1542AA8762DB13087D8364F3EA6509FD6F009A34F00426AF9E4F9FA85CBBF1F", | ||
| }, | ||
| OutputDenom: "ibc/D1542AA8762DB13087D8364F3EA6509FD6F009A34F00426AF9E4F9FA85CBBF1F", | ||
| Slippage: txfee_filters.Slippage{ |
There was a problem hiding this comment.
Some of the contracts allow to set slippage as a percentage instead of MinOutputAmount. Maybe we should consider that as an option too?
nicolaslara
reviewed
Dec 26, 2023
| return false | ||
| } | ||
|
|
||
| return true |
There was a problem hiding this comment.
If we want to be more strict here we can check that the input and output denoms are either (1) the same, or (2) in a list of equivalent denoms (usdc/usdt/axlusdc/etc)
There was a problem hiding this comment.
This should work for now, but we are considering any contract swap as an attack, instead of just arbs
czarcas7ic
pushed a commit
that referenced
this pull request
Dec 29, 2023
* refactor: arb filter for new authz exec swap * updates * updates * updates
czarcas7ic
added a commit
that referenced
this pull request
Dec 30, 2023
* Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <dojha@berkeley.edu> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: github-actions <github-actions@github.com>
mergify bot
pushed a commit
that referenced
this pull request
Dec 30, 2023
* Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <dojha@berkeley.edu> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit c5a5147) # Conflicts: # go.mod # go.sum # osmomath/go.sum
czarcas7ic
added a commit
that referenced
this pull request
Dec 30, 2023
* chore: catch up main to v21.1.x (#7215) * Reduce discrepancy in fee simulation * Update * State compatible applyFuncIfNoError event reduction * Update osmoutils/epochs versions * Update SDK version * One more epoch speedup * Speedup core loop of epoch * fix test (#7197) * refactor: auto-set timeout-commit to 4s for faster block times (#7196) * updates (#7192) * refactor: auto-set timeout-commit to 4s for faster block times (backport #7180) * changelog * Revert "updates (#7192)" This reverts commit 6cc26f9. * lint * Update changelog * Update changelog * changelog * Speedup multiplication * Try scratch slice * refactor: arb filter for new authz exec swap (#7210) * refactor: arb filter for new authz exec swap * updates * updates * updates * clean up * Auto: update go.mod after push to adam/v21.1.x-merge-to-main that modified dependencies locally * add 21.1.5 to changelog * update comment --------- Co-authored-by: Dev Ojha <dojha@berkeley.edu> Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: github-actions <github-actions@github.com> (cherry picked from commit c5a5147) # Conflicts: # go.mod # go.sum # osmomath/go.sum * go mod update * update go mods from v21.x --------- Co-authored-by: Adam Tucker <adam@osmosis.team> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
p0mvn
added a commit
that referenced
this pull request
Jan 2, 2024
czarcas7ic
added
A:backport/v21.x
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Detect this: https://celatone.osmosis.zone/osmosis-1/txs/8D20755D4E009CB72C763963A76886BCCCC5C2EBFC3F57266332710216A0D10D