Math Refactor #740
Merged
Math Refactor #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 18.73% 20.00% +1.27%
==========================================
Files 172 189 +17
Lines 23908 24559 +651
==========================================
+ Hits 4478 4914 +436
- Misses 18655 18790 +135
- Partials 775 855 +80
Continue to review full report at Codecov.
|
ValarDragon
reviewed
Jan 8, 2022
ValarDragon
reviewed
Jan 13, 2022
ValarDragon
reviewed
Jan 13, 2022
ValarDragon
reviewed
Jan 13, 2022
ValarDragon
reviewed
Jan 13, 2022
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
…/osmosis into mconcat/curve-math-refactor
|
ValarDragon
reviewed
Jan 19, 2022
| @@ -124,7 +124,7 @@ func (suite *KeeperTestSuite) TestCleanupPoolRandomized() { | |||
| for _, coin := range coinOf[acc.String()] { | |||
| amt := suite.app.BankKeeper.GetBalance(suite.ctx, acc, coin.Denom) | |||
| // the refund could have rounding error | |||
| suite.True(amt.Amount.Equal(coin.Amount) || amt.Amount.Equal(coin.Amount.SubRaw(1)), | |||
| suite.True(amt.Amount.Sub(coin.Amount).Abs().LTE(sdk.NewInt(2)), | |||
There was a problem hiding this comment.
Was there an error here, or just pro-actively changing it?
ValarDragon
approved these changes
Jan 19, 2022
ValarDragon
added a commit
that referenced
this pull request
Jan 19, 2022
* refactor math * factor out normalizedWeight * unify into SolveConstantFunctionInvariant * test in progress * add randomized test * Update x/gamm/keeper/math.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
|
This is on v6.x now, and syncing just fine! |
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swap math functions refactoring PR.
This PR does not (and should not) contain any mathematical level change(except for adding several
Neg()s), only code level changes.Description
For contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer