馃尡 Update Binary-Artifacts and License checks #4079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: seelder <[email protected]>
Updated the test to use scut. Updated the test data to use scut, including adding NumberOfInfo and NumberOfWarn for each test case Signed-off-by: seelder <[email protected]>
First attempt at updating license_test to use gomock instead of localDir. Note: localDir currently has a TODO for implementing ListLicenses. It returns an UnsupportedFeatures error, which is then handled in checks/raw/license. This first attempt replicates that existing behavior. Signed-off-by: seelder <[email protected]>
Clarified why the mock simply throws an error Signed-off-by: seelder <[email protected]>
Signed-off-by: seelder <[email protected]>
Signed-off-by: seelder <[email protected]>
seelder
requested review from
justaugustus and
raghavkaul
and removed request for
a team
seelder
changed the title
seelder
changed the title
spencerschrock
approved these changes
May 3, 2024
|
Thanks for picking up the issue. I made one small tweak to the PR body, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Updates tests to follow best practices (and corrects previous PR #4078 )
What is the current behavior?
binary_analysis and license check tests currently use localDirRepo instead of gomock
binary_analysis does not utilize scut (license test already uses scut and does not need modification)
What is the new behavior (if this is a feature change)?**
Which issue(s) this PR fixes
Fixes #4032