Transcript: support custom fix and overlay queue #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
winlinvip
reviewed
Aug 18, 2024
platform/transcript.go
Outdated
| // The total segments in overlay HLS. | ||
| const maxOverlaySegments = 9 | ||
| // The default total segments in overlay HLS. | ||
| const defaultMaxOverlaySegments = 9 |
There was a problem hiding this comment.
Should not repeat your code:
const defaultMaxOverlaySegments = 9
setEnvDefault("SRS_TRANSCRIPT_OVERLAY_QUEUE_LIMIT", "9")
winlinvip
reviewed
Aug 18, 2024
platform/transcript.go
Outdated
| const defaultMaxOverlaySegments = 9 | ||
|
|
||
| // Get the total segments in overlay HLS. | ||
| func GetMaxOverlaySegments() (int, error) { |
There was a problem hiding this comment.
The function GetMaxOverlaySegments should be designed to ignore any error:
func GetMaxOverlaySegments() (int, error)Use it in the transcript while ignoring any error:
maxOverlaySegments, _ := GetMaxOverlaySegments()In the doMain, after setEnvDefault, check for the error:
setEnvDefault("SRS_TRANSCRIPT_OVERLAY_QUEUE_LIMIT", "9")
if _, err := GetMaxOverlaySegments(); err != nil {
return errors.Wrapf(......)If the environment is not set as expected, it should fail in main, not in the transcript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.