Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary files used for Go 1.15 #135

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Remove unnecessary files used for Go 1.15 #135

merged 2 commits into from
Jan 9, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 8, 2024 •
edited
Loading

The PR removes file_info_go1.15.go, file_info_go1.16.go, and patherror_go1.15_test.go because these files have become unused as the project's version upgrades to Go 1.18.

@otiai10
Copy link
Owner

otiai10 commented Jan 8, 2024

great catch! thx!
Do you think we still need the clone interface?

@alexandear
Copy link
Contributor Author

No, the library doesn't need fileInfo interface. Removed it as well.

@otiai10
Copy link
Owner

otiai10 commented Jan 9, 2024

Thanks a lot!

@otiai10 otiai10 merged commit 2e7e0e6 into otiai10:main Jan 9, 2024
21 checks passed
@alexandear alexandear deleted the remove-unused-go-1.15-files branch January 9, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexandear @otiai10