Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete obsolete // +build lines #137

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Delete obsolete // +build lines #137

merged 1 commit into from
Jan 18, 2024

Conversation

alexandear
Copy link
Contributor

@alexandear alexandear commented Jan 8, 2024 •
edited
Loading

This PR removes outdated // +build build constraints. Use go fix ./... to remove the // +build lines that have become obsolete in Go 1.18. See https://go.dev/doc/go1.18#go-build-lines.

Alpine 3.16 is needed because it has Go 1.18.

@otiai10 otiai10 self-requested a review January 18, 2024 06:11
otiai10
otiai10 reviewed Jan 18, 2024
View reviewed changes
Copy link
Owner

@otiai10 otiai10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@otiai10 otiai10 merged commit 441a9cd into otiai10:main Jan 18, 2024
21 checks passed
@alexandear alexandear deleted the fix-buildtag branch January 18, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otiai10 otiai10 otiai10 left review comments

@tomaswarynyca tomaswarynyca tomaswarynyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexandear @otiai10 @tomaswarynyca