Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to follow symlinks #16

Closed
wants to merge 1 commit into from
Closed

Add an option to follow symlinks #16

wants to merge 1 commit into from

Conversation

yasushi-saito
Copy link
Contributor

No description provided.

@otiai10 otiai10 self-requested a review March 3, 2020 10:42
@otiai10
Copy link
Owner

otiai10 commented Mar 4, 2020

Related #15

Copy link
Owner

@otiai10 otiai10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case failing

@codecov-io
Copy link

codecov-io commented Mar 4, 2020

Codecov Report

Merging #16 into master will decrease coverage by 1.85%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage      84%   82.14%   -1.86%     
==========================================
  Files           1        1              
  Lines          50       56       +6     
==========================================
+ Hits           42       46       +4     
- Misses          4        5       +1     
- Partials        4        5       +1
Impacted Files Coverage Δ
copy.go 82.14% <84.61%> (-1.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f71bf16...a1d6619. Read the comment docs.

@@ -0,0 +1 @@
../case05/README.md
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get your point of adding this link. What is case06?

@otiai10
Copy link
Owner

otiai10 commented Mar 5, 2020

Hey, please don't force push after you open a pull-request...
I'm willing to do squash merge if you like...

@otiai10 otiai10 mentioned this pull request Mar 5, 2020
@otiai10
Copy link
Owner

otiai10 commented Mar 5, 2020

Moved to #17

@otiai10 otiai10 closed this Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants