Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Drop Python 3.7 support and complete poetry migration #1271

Merged
merged 30 commits into from
Apr 26, 2023

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented Apr 15, 2023

@github-actions
Copy link

github-actions bot commented Apr 15, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 5.47177 5.22 -4.6%
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 68.9094 67.8 -1.61%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 13.0514 12.76 -2.23%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #1271 (e3f2aa5) into main (0ea55d3) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1271      +/-   ##
==========================================
- Coverage   89.87%   89.85%   -0.03%     
==========================================
  Files          38       38              
  Lines        5078     5136      +58     
==========================================
+ Hits         4564     4615      +51     
- Misses        514      521       +7     
Impacted Files Coverage Δ
neuralprophet/forecaster.py 87.38% <100.00%> (ø)

... and 6 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@noxan noxan self-assigned this Apr 17, 2023
@noxan noxan added this to the Release 0.6.0 milestone Apr 17, 2023
@noxan noxan force-pushed the 1269-complete-poetry-migration branch 2 times, most recently from 199e9c2 to 01c97db Compare April 18, 2023 06:07
@noxan noxan force-pushed the 1269-complete-poetry-migration branch from a6c8571 to 3343bcd Compare April 19, 2023 06:02
@ourownstory ourownstory linked an issue Apr 19, 2023 that may be closed by this pull request
3 tasks
@noxan noxan added the status: in development Pull requests which are in development label Apr 21, 2023
@ourownstory ourownstory modified the milestones: Release 0.6.0, 0.6.1 Apr 21, 2023
@noxan
Copy link
Collaborator Author

noxan commented Apr 21, 2023

Follow up task #1299

@ourownstory ourownstory modified the milestones: 0.6.1, Release 1.0.0 RC1 Apr 24, 2023
@noxan noxan changed the title [minor] Complete poetry migration [devops] Complete poetry migration Apr 26, 2023
@noxan noxan changed the title [devops] Complete poetry migration [major] Drop Python 3.7 support and complete poetry migration Apr 26, 2023
@noxan noxan marked this pull request as ready for review April 26, 2023 00:20
@noxan noxan requested a review from leoniewgnr April 26, 2023 02:09
@noxan noxan added status: needs review PR needs to be reviewed by Reviewer(s) and removed status: in development Pull requests which are in development labels Apr 26, 2023
Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noxan noxan merged commit 45111be into main Apr 26, 2023
@noxan noxan deleted the 1269-complete-poetry-migration branch April 26, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete poetry migration
4 participants