[minor] Add static plotly backend #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1286 +/- ##
==========================================
+ Coverage 89.82% 89.84% +0.01%
==========================================
Files 38 38
Lines 5142 5149 +7
==========================================
+ Hits 4619 4626 +7
Misses 523 523
|
…t default static display type to svg
LeonieFreisinger
added
the
status: needs review
| @@ -339,6 +347,8 @@ def plot_components( | |||
| for ax in multiplicative_axes: | |||
| ax = set_y_as_percent(ax) | |||
| unregister_plotly_resampler() | |||
| if plotly_static: | |||
There was a problem hiding this comment.
@hxyue1 I am wondering, if in the 'plotly_static' case, we will display the figure twice if calling another .show() when applying the plot function?
LeonieFreisinger
requested changes
Apr 21, 2023
There was a problem hiding this comment.
Hey @hxyue1! Thanks a lot for your work in this PR. Looks generally good to me. :)
3 points to touch upon:
- if we call a
fig.show()in the 'plotly_static' case and return thefig, do we run in a problem of plotting it twice with this function call. - can you edit the
test_plot()in the test_plotting.pywith testing the 'plotly_static' ? I think it would be good the have it checked via at least one test. Editing all tests would be a little much. Would be great to also add theplotly_resampleron that go - Can as well adjust the plotly tutorial with the update of the
plotly_staticbackend?
LeonieFreisinger
approved these changes
Apr 26, 2023
|
@hxyue1 please have a final look at resolving the merge conflict. Afterwards, feel free to merge. |
leoniewgnr
added
status: ready
5 tasks
Model Benchmark
Model training plotsModel TrainingPeytonManningYosemiteTempsAirPassengers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔬 Background
This mostly resolves #1235. I'm not sure how to proceed with plots for the conformal class since it has a different implementation.
🔮 Key changes
Adds argument that allows users to select a static display type. If this is specified, it sets the backend to plotly and then displays the plot in the specified type. The interactive plot is still returned from the function call.
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.