Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devops] Remove macos and windows from Github actions #1325

Merged
merged 2 commits into from
May 13, 2023
Merged

Conversation

noxan
Copy link
Collaborator

@noxan noxan commented May 10, 2023

🔬 Background

  • There has not been any difference between the operating systems so far

🔮 Key changes

@noxan noxan requested a review from ourownstory May 10, 2023 06:42
@noxan noxan added the status: needs review PR needs to be reviewed by Reviewer(s) label May 10, 2023
@github-actions
Copy link

github-actions bot commented May 10, 2023

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.58159 0.58159 -0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 -0.0%
PeytonManning MAE 0.41671 0.41671 -0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 15.8306 12.36 -21.92% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 -0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 -0.0%
YosemiteTemps Loss_val 0.00077 0.00077 -0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 -0.0%
YosemiteTemps Loss 0.00064 0.00064 -0.0%
YosemiteTemps time 73.3385 56.63 -22.78% 🎉
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9452 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.55573 5.18 -20.99% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov-commenter
Copy link

codecov-commenter commented May 10, 2023

Codecov Report

Merging #1325 (5b968cd) into main (da04620) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   89.83%   89.85%   +0.01%     
==========================================
  Files          38       38              
  Lines        5104     5104              
==========================================
+ Hits         4585     4586       +1     
+ Misses        519      518       -1     

see 1 file with indirect coverage changes

Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we decided only to remove macos

Copy link
Owner

@ourownstory ourownstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thank you!
Until we remove matplotlib support (or potentially longer), I suggest we keep windows test to catch any plotting package dependency/build issues.

@noxan
Copy link
Collaborator Author

noxan commented May 13, 2023

Windows tests fail frequently due to "This probably means that Tcl wasn't installed properly."

Also why should there be any different dependency or build issues on windows?

@noxan noxan merged commit e924677 into main May 13, 2023
@noxan noxan deleted the remove-other-os branch May 13, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows tests in github actions fail
4 participants