-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[devops] Remove macos and windows from Github actions #1325
Conversation
Model Benchmark
|
Codecov Report
@@ Coverage Diff @@
## main #1325 +/- ##
==========================================
+ Coverage 89.83% 89.85% +0.01%
==========================================
Files 38 38
Lines 5104 5104
==========================================
+ Hits 4585 4586 +1
+ Misses 519 518 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we decided only to remove macos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thank you!
Until we remove matplotlib support (or potentially longer), I suggest we keep windows test to catch any plotting package dependency/build issues.
Windows tests fail frequently due to "This probably means that Tcl wasn't installed properly." Also why should there be any different dependency or build issues on windows? |
🔬 Background
🔮 Key changes