Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove type conversion for _stride_lagged_features and _stride_future… #1331

Merged
merged 1 commit into from
May 24, 2023

Conversation

hxyue1
Copy link
Collaborator

@hxyue1 hxyue1 commented May 17, 2023

…_time_features_for_forecasts

🔬 Background

This fixes #1317.

🔮 Key changes

I removed the datetime conversions for _stride_time_features_for_forecasts and _stride_future_time_features_for_forecasts.

📋 Review Checklist

  • I have performed a self-review of my own code.
  • I have commented my code, added docstrings and data types to function definitions.
  • I have added pytests to check whether my feature / fix works.

Please make sure to follow our best practices in the Contributing guidelines.

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #1331 (24e34ef) into main (24fd354) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1331      +/-   ##
==========================================
+ Coverage   89.86%   89.88%   +0.02%     
==========================================
  Files          38       38              
  Lines        5109     5103       -6     
==========================================
- Hits         4591     4587       -4     
+ Misses        518      516       -2     
Impacted Files Coverage Δ
neuralprophet/time_dataset.py 95.43% <100.00%> (+0.55%) ⬆️

@leoniewgnr leoniewgnr assigned leoniewgnr and hxyue1 and unassigned leoniewgnr May 19, 2023
@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label May 19, 2023
Copy link
Collaborator

@leoniewgnr leoniewgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ready to be merged if tests pass

@ourownstory ourownstory merged commit ac4aa98 into ourownstory:main May 24, 2023
@github-actions
Copy link

Model Benchmark

Benchmark Metric main current diff
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 16.2654 14.81 -8.95% 🎉
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 74.683 71.47 -4.3%
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.70337 6.28 -6.32% 🎉
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Float32 target values encounter TypeError: can't convert np.ndarray of type numpy.datetime64.
3 participants