Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] fixed prediction_frequency when quantiles are set #1347

Merged
merged 2 commits into from
Jun 13, 2023

Conversation

leoniewgnr
Copy link
Collaborator

🔬 Background

see #1346

🔮 Key changes

only used first dimension of components[comp]

@leoniewgnr
Copy link
Collaborator Author

can anybody confirm that the first dimension of component[comp] corresponds to the 50% forecast?

@leoniewgnr leoniewgnr self-assigned this Jun 12, 2023
@leoniewgnr leoniewgnr added the status: needs review PR needs to be reviewed by Reviewer(s) label Jun 12, 2023
@github-actions
Copy link

github-actions bot commented Jun 12, 2023

Model Benchmark

Benchmark Metric main current diff
YosemiteTemps MAE_val 1.3442 1.3442 0.0%
YosemiteTemps RMSE_val 2.00245 2.00245 0.0%
YosemiteTemps Loss_val 0.00077 0.00077 0.0%
YosemiteTemps MAE 1.3192 1.3192 0.0%
YosemiteTemps RMSE 2.13518 2.13518 0.0%
YosemiteTemps Loss 0.00064 0.00064 0.0%
YosemiteTemps time 73.103 71.07 -2.78%
PeytonManning MAE_val 0.58159 0.58159 0.0%
PeytonManning RMSE_val 0.72216 0.72216 0.0%
PeytonManning Loss_val 0.01239 0.01239 0.0%
PeytonManning MAE 0.41671 0.41671 0.0%
PeytonManning RMSE 0.55961 0.55961 0.0%
PeytonManning Loss 0.00612 0.00612 0.0%
PeytonManning time 14.8921 14.83 -0.42%
AirPassengers MAE_val 13.0626 13.0626 0.0%
AirPassengers RMSE_val 15.9453 15.9453 0.0%
AirPassengers Loss_val 0.00131 0.00131 0.0%
AirPassengers MAE 9.88156 9.88156 0.0%
AirPassengers RMSE 11.7354 11.7354 0.0%
AirPassengers Loss 0.00052 0.00052 0.0%
AirPassengers time 6.42825 6.34 -1.37%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

@codecov
Copy link

codecov bot commented Jun 12, 2023

Codecov Report

Merging #1347 (e143bdc) into main (8465b40) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1347   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          38       38           
  Lines        5103     5103           
=======================================
  Hits         4587     4587           
  Misses        516      516           
Impacted Files Coverage Δ
neuralprophet/data/process.py 92.56% <100.00%> (ø)

@leoniewgnr leoniewgnr requested review from LeonieFreisinger and removed request for ourownstory June 12, 2023 21:55
@leoniewgnr leoniewgnr marked this pull request as ready for review June 13, 2023 01:32
Copy link
Collaborator

@LeonieFreisinger LeonieFreisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leoniewgnr leoniewgnr merged commit b39b468 into main Jun 13, 2023
@leoniewgnr leoniewgnr deleted the fix-prediction-frequency branch June 13, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs review PR needs to be reviewed by Reviewer(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants