-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Add a verbose option to NeuralProphet.test #1407
Conversation
@c3-ziqin this is really cool! Let me fix the linter ruff warnings before, then we are able to merge that, thanks a lot! |
Codecov Report
@@ Coverage Diff @@
## main #1407 +/- ##
=======================================
Coverage 89.87% 89.87%
=======================================
Files 38 38
Lines 5067 5067
=======================================
Hits 4554 4554
Misses 513 513
|
@c3-ziqin shouldn't we set the default to |
Ah now the default was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes can confirm the default was True as pytorch_lightning.Trainer.test has verbose=True |
Model Benchmark
|
🔬 Background
resolves #1367
🔮 Key changes
Add a
verbose
arg toNeuralProphet.test
, surfacing the verbose option ontrainer.test
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.