Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Training: update 1cycle lr to 3phase #1450

Merged
merged 15 commits into from
Nov 6, 2023
Merged

Conversation

ourownstory
Copy link
Owner

Updating the OneCycle learning rate scheduler to the updated version that is closer to the original paper implementation.
As added in pytorch/pytorch#42715

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Merging #1450 (135879a) into main (962d624) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1450   +/-   ##
=======================================
  Coverage   88.32%   88.32%           
=======================================
  Files          38       38           
  Lines        5097     5097           
=======================================
  Hits         4502     4502           
  Misses        595      595           
Files Coverage Δ
neuralprophet/configure.py 90.18% <ø> (ø)

@github-actions
Copy link

github-actions bot commented Oct 15, 2023

Model Benchmark

Benchmark Metric main current diff
AirPassengers MAE_val 31.6338 32.4076 2.45%
AirPassengers RMSE_val 32.6669 33.7803 3.41% ⚠️
AirPassengers Loss_val 0.01372 0.0044 -67.92% 🎉
AirPassengers MAE 6.24137 5.97509 -4.27%
AirPassengers RMSE 7.82929 7.60547 -2.86%
AirPassengers Loss 0.00063 0.0002 -69.04% 🎉
AirPassengers time 15.3729 22.22 44.54%
EnergyPriceDaily MAE_val 5.55889 6.1255 10.19%
EnergyPriceDaily RMSE_val 7.12233 7.82607 9.88%
EnergyPriceDaily Loss_val 0.02829 0.01031 -63.57% 🎉
EnergyPriceDaily MAE 6.37172 6.86841 7.8%
EnergyPriceDaily RMSE 8.53016 9.16023 7.39%
EnergyPriceDaily Loss 0.02907 0.01064 -63.41% 🎉
EnergyPriceDaily time 22.2576 33.25 49.39%
PeytonManning MAE_val 0.3466 0.34637 -0.07%
PeytonManning RMSE_val 0.49808 0.49818 0.02%
PeytonManning Loss_val 0.01752 0.00593 -66.16% 🎉
PeytonManning MAE 0.34735 0.35203 1.35%
PeytonManning RMSE 0.48788 0.48856 0.14%
PeytonManning Loss 0.01457 0.00463 -68.23% 🎉
PeytonManning time 30.31 44.31 46.19%
YosemiteTemps MAE_val 0.64178 0.69362 8.08%
YosemiteTemps RMSE_val 0.92787 0.99669 7.42%
YosemiteTemps Loss_val 0.0005 0.00017 -65.38% 🎉
YosemiteTemps MAE 1.092 1.15427 5.7% ⚠️
YosemiteTemps RMSE 1.89124 1.98089 4.74% ⚠️
YosemiteTemps Loss 0.00155 0.00051 -66.98% 🎉
YosemiteTemps time 83.433 135.82 62.79%
Model training plots

Model Training

PeytonManning

YosemiteTemps

AirPassengers

EnergyPriceDaily

@ourownstory ourownstory changed the title update 1cycle lr to 3phase [Major] update 1cycle lr to 3phase Oct 18, 2023
@SimonWittner SimonWittner merged commit 4b8ccdb into main Nov 6, 2023
13 checks passed
@SimonWittner SimonWittner deleted the 3phase-1cycle branch November 6, 2023 20:16
@ourownstory ourownstory changed the title [Major] update 1cycle lr to 3phase [major] Training: update 1cycle lr to 3phase Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants