[Minor] fix future regressor #1585
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1585 +/- ##
=======================================
Coverage 88.16% 88.16%
=======================================
Files 41 41
Lines 5374 5366 -8
=======================================
- Hits 4738 4731 -7
+ Misses 636 635 -1 ☔ View full report in Codecov by Sentry. |
neuralprophet/forecaster.py
Outdated
| @@ -1107,7 +1112,7 @@ def fit( | |||
| self.fitted = True | |||
| return metrics_df | |||
|
|
|||
| def predict(self, df: pd.DataFrame, decompose: bool = True, raw: bool = False): | |||
| def predict(self, df: pd.DataFrame, decompose: bool = True, raw: bool = False, auto_extend=False): | |||
There was a problem hiding this comment.
To avoid the linked issues being raised, auto_extend should default to True, unless my logic is off?
There was a problem hiding this comment.
auto_extend for me means that we don't do the cutting at the end. So we cut all the time except for the case where it will cause the whole dataframe to be nan. Can still reverse it
neuralprophet/forecaster.py
Outdated
| @@ -749,6 +749,7 @@ def add_events( | |||
| def add_country_holidays( | |||
| self, | |||
| country_name: Union[str, list], | |||
| subdivision_name: Optional[Union[str, dict]] = None, | |||
There was a problem hiding this comment.
seems like the subdivision commits slipped in here.
we can either remove those commits or merge that PR first and be careful that these lines do not longer reappear due to commit squashing.
neuralprophet/configure.py
Outdated
| @@ -397,12 +397,12 @@ def __post_init__(self): | |||
| self.seasonality_local_reg = False | |||
|
|
|||
| # If seasonality_local_reg = True | |||
| if self.seasonality_local_reg == True: | |||
| if self.seasonality_local_reg: | |||
There was a problem hiding this comment.
This also seems to come from another PR
There was a problem hiding this comment.
Also, this change will always override a set seasonality_local_reg and overwrite it to be 1 which does not appear intentional?
There was a problem hiding this comment.
No was trying to solve the flake8 errors - doesn't make any difference anyways
…/neural_prophet into bug/1567-fix-future-regressor
Model Benchmark
\n
Model training plots\n ## Model Training ### PeytonManning  ### YosemiteTemps  ### AirPassengers  ### EnergyPriceDaily  \n |
🔬 Background
🔮 Key changes
📋 Review Checklist
Please make sure to follow our best practices in the Contributing guidelines.