New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4588 #4804

Merged

Jarred-Sumner merged 3 commits into main from jarred/fixes-4588

Sep 11, 2023

Collaborator

Jarred-Sumner commented Sep 10, 2023

What does this PR do?

Adds navigator.platform as a global

https://developer.mozilla.org/en-US/docs/Web/API/Navigator/platform

Fixes #4588

Supersedes #4739

How did you verify your code works?

Tests


          Fixes #4588

d8937df

Jarred-Sumner mentioned this pull request

Add navigator.platform polyfill #4739

Closed

6 tasks


          typo

62a6514

paperdave reviewed

View reviewed changes

test/js/web/web-globals.test.js Outdated Show resolved Hide resolved


          fixup

f9d516a

Jarred-Sumner merged commit edea4f0 into main

11 checks passed

Jarred-Sumner deleted the jarred/fixes-4588 branch

September 11, 2023 04:40

Contributor

github-actions bot commented Sep 11, 2023

❌ @Jarred-Sumner 5 files with test failures on bun-darwin-aarch64:

test/bundler/esbuild/default.test.ts
test/cli/install/bunx.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/watch/fs.watch.test.ts

View test output

^{#f4b5fae7508cb3da9e92aa1f62723cf0a9255cbd}

Contributor

github-actions bot commented Sep 11, 2023

❌ @Jarred-Sumner 3 files with test failures on linux-x64:

test/js/bun/util/filesink.test.ts
test/js/node/watch/fs.watchFile.test.ts
test/js/web/fetch/fetch-gzip.test.ts

View test output

^{#f4b5fae7508cb3da9e92aa1f62723cf0a9255cbd}

Contributor

github-actions bot commented Sep 11, 2023

❌ @Jarred-Sumner 8 files with test failures on bun-darwin-x64-baseline:

test/cli/install/bun-install.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/util/filesink.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watchFile.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setInterval.test.js
test/js/web/timers/setTimeout.test.js

View test output

^{#f4b5fae7508cb3da9e92aa1f62723cf0a9255cbd}

paperdave pushed a commit to SuperAuguste/bun that referenced this pull request


          Fixes oven-sh#4588 (oven-sh#4804)

ee9dc14

* Fixes oven-sh#4588

* typo

* fixup

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet