Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack test, fix errors in Worker #7980

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Fix webpack test, fix errors in Worker #7980

merged 7 commits into from
Jan 4, 2024

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

This should fix one of the debug assertion failures

How did you verify your code works?

Ran some tests manually

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

❌ @Jarred-Sumner 3 files with test failures on bun-darwin-aarch64:

  • test/cli/test/bun-test.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#86909329547febf40effb329130ba3cfd85dddee

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

❌ @Jarred-Sumner 4 files with test failures on linux-x64:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/third_party/jsonwebtoken/claim-aud.test.js
  • test/js/third_party/webpack/webpack.test.ts

View test output

#86909329547febf40effb329130ba3cfd85dddee

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

❌ @Jarred-Sumner 4 files with test failures on linux-x64-baseline:

  • test/cli/test/bun-test.test.ts
  • test/integration/next/default-pages-dir/test/next-build.test.ts
  • test/js/node/http2/node-http2.test.js
  • test/js/third_party/webpack/webpack.test.ts

View test output

#86909329547febf40effb329130ba3cfd85dddee

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

❌ @Jarred-Sumner 4 files with test failures on bun-darwin-x64-baseline:

  • test/cli/test/bun-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#86909329547febf40effb329130ba3cfd85dddee

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024 •
edited
Loading

❌ @Jarred-Sumner 5 files with test failures on bun-darwin-x64:

  • test/cli/test/bun-test.test.ts
  • test/js/bun/util/which.test.ts
  • test/js/node/fs/fs.test.ts
  • test/js/node/watch/fs.watchFile.test.ts
  • test/js/third_party/webpack/webpack.test.ts

View test output

#86909329547febf40effb329130ba3cfd85dddee

@Jarred-Sumner Jarred-Sumner changed the title In Bun.spawn, prevent calling unprotect on a ReadableStream which was not protected Fix webpack test Jan 4, 2024
@Jarred-Sumner Jarred-Sumner changed the title Fix webpack test Fix webpack test, fix errors in Worker Jan 4, 2024
@Jarred-Sumner Jarred-Sumner merged commit 47acee5 into main Jan 4, 2024
25 of 30 checks passed
@Jarred-Sumner Jarred-Sumner deleted the jarred/spawn-detach branch January 4, 2024 10:57
@Jarred-Sumner Jarred-Sumner mentioned this pull request Jan 4, 2024
Open
ryoppippi pushed a commit to ryoppippi/bun that referenced this pull request Feb 1, 2024
@Jarred-Sumner @ryoppippi
Fix webpack test, fix errors in Worker (oven-sh#7980)
af91276 
* Update subprocess.zig

* Fix logging errors in Worker

* Update webpack.test.ts

* Update webpack.test.ts

* 😪

* Fix `self` setter

* Set IsImmutablePrototypeExoticObject and make globalThis.self = work

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Jarred-Sumner