Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResolveInfo injection in Query #1191

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

Vincz
Copy link
Collaborator

@Vincz Vincz commented Aug 8, 2024

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? yes
Fixed tickets #1186
License MIT

This PR allows to inject the ResolveInfo into a query or mutation just by adding it to the list of auto-guessed arguments.

Exemple:

#[Query]
public function test(int $id, ResolveInfo $info) {

}

It only works with annotations/attributes and auto-guess parameters when the query resolver is auto-generated.

@AlexOstrovsky
Copy link

@mcg-web can you please check and review this PR. we need this to update to latest version of this bundle. Thank you very much.

@AlexOstrovsky
Copy link

@mcg-web any update on this please?

@mcg-web
Copy link
Member

mcg-web commented Aug 26, 2024

Thank you @Vincz, also sorry for the late review !

@mcg-web mcg-web merged commit a8c5661 into overblog:master Aug 26, 2024
42 checks passed
@AlexOstrovsky
Copy link

@mcg-web can you also please create a release with this feature? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants