Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass arguments from expression function #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kix
Copy link
Contributor

@kix kix commented Jan 21, 2020

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Documented? no
Fixed tickets none
License MIT

Previously, if I was passing arguments to my resolvers with the expression function, I would get null instead of an instance if the query has no arguments (e.g. no parens at all in GQL).

However, this breaks resolvers that require an instance argument. This makes @arguments always try to return an instance of an InputObject whenever it is required.

Previously, if I was passing arguments to my resolvers with the
expression function, I would get `null` instead of an instance if the
query has no arguments (e.g. no parens at all in GQL).

However, this breaks resolvers that require an instance argument. This
makes `@arguments` always try to return an instance of an InputObject
whenever it is required.
@kix kix requested a review from mcg-web January 21, 2020 20:54
@murtukov murtukov requested review from Vincz and removed request for mcg-web July 9, 2020 18:20
@murtukov
Copy link
Member

murtukov commented Jul 9, 2020

ArgumentsTransformer is @Vincz's stuff. Ping 📡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants