Skip to content
This repository has been archived by the owner on Apr 14, 2024. It is now read-only.

Remove Terraform prevent_destroy #10484

Merged
merged 1 commit into from
Apr 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions terraform/app_environment/modules/aws_cloudfront/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ resource "aws_cloudfront_distribution" "assets" {
}
}

lifecycle {
prevent_destroy = true
}

logging_config {
bucket = var.logs_domain
prefix = "AWSLogs/${data.aws_caller_identity.main.account_id}/cloudfront/${var.name}/"
Expand Down
4 changes: 0 additions & 4 deletions terraform/app_environment/modules/aws_cognito/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,6 @@ resource "aws_cognito_user_pool" "app" {
allow_admin_create_user_only = true
}

lifecycle {
prevent_destroy = true
}

schema {
attribute_data_type = "String"
mutable = true
Expand Down
8 changes: 0 additions & 8 deletions terraform/app_environment/modules/aws_s3/main.tf
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
resource "aws_s3_bucket" "assets" {
bucket = var.name

lifecycle {
prevent_destroy = true
}

lifecycle_rule {
abort_incomplete_multipart_upload_days = 1
enabled = true
Expand Down Expand Up @@ -37,10 +33,6 @@ resource "aws_s3_bucket" "logs" {
acl = "log-delivery-write"
bucket = "${var.name}-logs"

lifecycle {
prevent_destroy = true
}

lifecycle_rule {
abort_incomplete_multipart_upload_days = 1
enabled = true
Expand Down
20 changes: 0 additions & 20 deletions terraform/app_environment/modules/heroku/main.tf
Original file line number Diff line number Diff line change
@@ -1,37 +1,21 @@
resource "heroku_addon" "app_postgresql" {
app_id = heroku_app.app.id
plan = "heroku-postgresql:mini"

lifecycle {
prevent_destroy = true
}
}

resource "heroku_addon" "app_rollbar" {
app_id = heroku_app.app.id
plan = "rollbar:trial-5k"

lifecycle {
prevent_destroy = false
}
}

resource "heroku_addon" "app_scheduler" {
app_id = heroku_app.app.id
plan = "scheduler:standard"

lifecycle {
prevent_destroy = true
}
}

resource "heroku_addon" "app_scout" {
app_id = heroku_app.app.id
plan = "scout:chair"

lifecycle {
prevent_destroy = false
}
}

resource "heroku_app" "app" {
Expand All @@ -44,10 +28,6 @@ resource "heroku_app" "app" {
"heroku/ruby",
]

lifecycle {
prevent_destroy = true
}

sensitive_config_vars = {
AWS_ACCESS_KEY_ID = var.aws_access_key_id
AWS_COGNITO_CLIENT_ID = var.aws_cognito_client_id
Expand Down